feat: Add sameSite configuration to happy_sticky_session cookie #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- configuration is optional with a default of "Lax"
sfitzgerald-czi
requested review from
patangay
and removed request for
a team
|
@jakeyheath @alexlokshin-czi @jacoblerner-czi not sure how to add you guys as reviewers |
sfitzgerald-czi
changed the title
alexlokshin-czi
approved these changes
Jan 30, 2025
|
Please re-create this PR without using a fork. |
|
|
Closing this cross-fork pr with one against happy repo (now that I have push access) #3819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration is optional with a default of "Lax"
Along needs this feature for sticky sessions when running in an iframe, configured as
SameSite"None""Lax" is the default setting for all major browsers.