Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin argcomplete version #660

Closed
wants to merge 1 commit into from

Conversation

msto
Copy link

@msto msto commented Nov 8, 2023

Hi,

Would it be possible to unpin the argcomplete dependency?

Thanks!

Motivation

We have an existing environment in which we'd like to use miniwdl, but there's a dependency conflict with the pinned version of argcomplete.

Approach

Loosening the dependency requirement to >=1.12 resolves the conflicts in our environment and doesn't appear to be breaking.

Checklist

  • Add appropriate test(s) to the automatic suite
  • Use make pretty to reformat the code with black
  • Use make check to statically check the code using Pyre and Pylint
  • Send PR from a dedicated branch without unrelated edits
  • Ensure compatibility with this project's MIT license

@mlin
Copy link
Collaborator

mlin commented Nov 19, 2023

@msto @geoffjentry Updated the argcomplete dependency in #662. I found the unit test needed some updates, and then this feature always needs manual/interactive testing, which I did. Thanks!

@mlin mlin closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants