Make export function preserve types #666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This should fix #665.
Approach
I made the
@export
annotation function generic so it returns the same type as its input.Checklist
make pretty
to reformat the code with blackmake check
to statically check the code using Pyre and PylintDoes not work,
pyre-check==0.0.27
is required according torequirements-dev.txt
, which is not available for any Python newer than 3.6, which ended security support on 23 Dec 2021. Currentpyre-check
versions do not have the--show-parse-errors
option used in the script.