Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make export function preserve types #666

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

adamnovak
Copy link
Contributor

Motivation

This should fix #665.

Approach

I made the @export annotation function generic so it returns the same type as its input.

Checklist

  • Add appropriate test(s) to the automatic suite
  • Use make pretty to reformat the code with black
  • Use make check to statically check the code using Pyre and Pylint
    Does not work, pyre-check==0.0.27 is required according to requirements-dev.txt, which is not available for any Python newer than 3.6, which ended security support on 23 Dec 2021. Current pyre-check versions do not have the --show-parse-errors option used in the script.
  • Send PR from a dedicated branch without unrelated edits
  • Ensure compatibility with this project's MIT license

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7230689392

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.191%

Totals Coverage Status
Change from base Build 6923130559: 0.03%
Covered Lines: 7363
Relevant Lines: 7735

💛 - Coveralls

@mlin
Copy link
Collaborator

mlin commented Dec 16, 2023

Thanks @adamnovak! The repo definitely needs some modernization of all the supporting tooling in the coming year. Building an agenda in #668

@mlin mlin merged commit b82e9da into chanzuckerberg:main Dec 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MyPy thinks WDL._util.strip_leading_whitespace is a str and not a function.
3 participants