Skip to content

Commit

Permalink
Remove unnecessary test
Browse files Browse the repository at this point in the history
  • Loading branch information
aganders3 committed Jan 21, 2025
1 parent 30a5f9d commit 5b88840
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions data-workflows/plugin/tests/test_processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,22 +152,6 @@ def test_stale_plugin_in_dynamo(
put_pm_calls = [_create_put_pm_call(PMType.PYPI)]
verify_calls(put_pm_calls=put_pm_calls)

def test_non_normalized_plugin_name(self, verify_calls):
non_normalized_plugin_name = PLUGIN.upper()
self._dynamo_latest_plugins = {
PLUGIN: VERSION,
non_normalized_plugin_name: VERSION,
}
self._pypi_latest_plugins = {"foo": VERSION}

processor.update_plugin()

self._zulip.assert_not_called()
put_pm_calls = [
_create_put_pm_call(PMType.PYPI, name=non_normalized_plugin_name)
]
verify_calls(put_pm_calls=put_pm_calls)

@pytest.mark.parametrize(
"existing_types, put_pm_data, formatted_metadata",
[
Expand Down Expand Up @@ -266,10 +250,8 @@ def test_replace_old_plugin_version_with_new(
self._zulip.assert_not_called()


def _create_put_pm_call(
pm_type, data=None, is_latest=False, version=VERSION, name=PLUGIN
) -> call:
kwargs = {"plugin": name, "version": version, "plugin_metadata_type": pm_type}
def _create_put_pm_call(pm_type, data=None, is_latest=False, version=VERSION) -> call:
kwargs = {"plugin": PLUGIN, "version": version, "plugin_metadata_type": pm_type}
if is_latest:
kwargs["is_latest"] = is_latest

Expand Down

0 comments on commit 5b88840

Please sign in to comment.