New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor CLI settings so that they don't depend on unnecessary variables #112

Merged

rzlim08 merged 3 commits into main from rlim/refactor-settings-cli

Oct 11, 2024

Collaborator

rzlim08 commented Oct 10, 2024

CLISettings probably shouldn't depend on having CERBOS_URL/S3 etc. variables set


          refactor CLI settings so that they don't depend on unnecessary variables

3129da3

rzlim08 requested a review from jgadling

October 10, 2024 21:42


          move BOTO_ENDPOINT_URL and AWS_REGION back into general settings

jgadling approved these changes

View reviewed changes


          move properties

b3ae6e2

rzlim08 merged commit 0fd06a6 into main

4 checks passed

rzlim08 deleted the rlim/refactor-settings-cli branch

October 11, 2024 16:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet