baseline platformics CI #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 30, 2024 16:57
ninabernick
force-pushed
the
ninabernick/ci
branch
from
d73e6cf to
35aa83b
Compare
ninabernick
force-pushed
the
ninabernick/ci
branch
from
b97d14d to
e9a92af
Compare
ninabernick
force-pushed
the
ninabernick/ci
branch
2 times, most recently
from
c045b29 to
2b16785
Compare
ninabernick
force-pushed
the
ninabernick/ci
branch
from
2b16785 to
e773f07
Compare
added 8 commits
June 4, 2024 14:58
Closed
ninabernick
commented
Jun 5, 2024
| @@ -46,6 +46,7 @@ init: | |||
| $(docker_compose_run) $(APP_CONTAINER) sh -c 'strawberry export-schema main:schema > /app/api/schema.graphql' | |||
| sleep 5 # wait for the app to reload after having files updated. | |||
| docker compose up -d | |||
| sleep 5 | |||
There was a problem hiding this comment.
added because the following line was unable to connect to the port
jgadling
reviewed
Jun 5, 2024
.github/workflows/build-and-test.yml
Outdated
| name: Build and test | ||
|
|
||
| on: | ||
| push |
There was a problem hiding this comment.
I think we only want to run this on PR's, and on the main branch, rather than every pushed commit.
jgadling
reviewed
Jun 5, 2024
.github/workflows/build-and-test.yml
Outdated
| jobs: | ||
| cancel-previous: | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
This should probably only cancel previous builds on the same branch, rather than all in-progress builds
There was a problem hiding this comment.
I think it does by default! But also apparently I can just use concurrency instead
jgadling
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up two workflows:
Could be combined into a single build + push + test workflow if we wanted.
In the future, we could build and push docker images on every push and also use caching to speed up builds.