feat: support LinkML field names with spaces. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgadling
commented
Jul 10, 2024
| @@ -25,19 +25,19 @@ def __getattr__(self, attr: str) -> str: | |||
| """ | |||
| Error if a property doesn't exist | |||
| """ | |||
| raise NotImplementedError(f"please define field property {attr}") | |||
| raise NotImplementedError(f"please define field property {self.wrapped_field.name}.{attr}") | |||
There was a problem hiding this comment.
Just making the error messages a little more verbose / easier to debug.
jgadling
commented
Jul 10, 2024
| @@ -507,7 +507,7 @@ async def create_{{ cls.snake_name }}( | |||
| cerbos_client: CerbosClient = Depends(get_cerbos_client), | |||
| principal: Principal = Depends(require_auth_principal), | |||
| is_system_user: bool = Depends(is_system_user), | |||
| ) -> db.Entity: | |||
| ) -> db.{{ cls.name }}: | |||
There was a problem hiding this comment.
These return the current type, there's no reason to tell the type checker that we return the base type. I think. 😅
jgadling
commented
Jul 10, 2024
| @@ -293,6 +293,8 @@ classes: | |||
| annotations: | |||
| minimum_length: 3 | |||
| maximum_length: 8 | |||
| field with spaces: | |||
| range: string | |||
There was a problem hiding this comment.
An example of a field with spaces in its name!
jgadling
commented
Jul 10, 2024
| } | ||
| """ | ||
| output = await gql_client.query(query, user_id=user_id, member_projects=[project_id]) | ||
| assert cct.field_with_spaces == output["data"]["constraintCheckedTypes"][0]["fieldWithSpaces"] |
There was a problem hiding this comment.
Check that this field is wired up properly from the test infrastructure all the way to the GQL interface!
ninabernick
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
This adds support for LinkML fields with spaces. The spaces are converted to underscores when we write out
snake_casefield names, and then get converted tocamelCaseproperly at word boundaries (basically just in the GQL interface)