Revert custom queries and mutations #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-x-han
commented
Jul 12, 2024
| @@ -1,17 +0,0 @@ | |||
| import strawberry | |||
There was a problem hiding this comment.
This PR currently removes custom_mutations.py and custom_queries.py entirely, but I could see it being helpful to leave the files there as templates and just removing the mutations/queries (or commenting them out). LMK which is preferred!
There was a problem hiding this comment.
Yeah I think we could have an examples folder for that kind of thing?
There was a problem hiding this comment.
sgtm, I'll merge this one as-is for now and we can set up examples in a follow up 😄
jgadling
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #77
Removes the code for custom queries and mutations from
test_app, since they're not relevant as defaults for a starting point. The code for adding custom queries/mutations is also already contained in the doc, which this PR does not remove.