-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move continuous fields to the dataset drawer if there is a single value for all cells #918
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
==========================================
- Coverage 77.47% 77.27% -0.21%
==========================================
Files 88 90 +2
Lines 6856 7024 +168
==========================================
+ Hits 5312 5428 +116
- Misses 1544 1596 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much work would it be to add a test for this? Could we write a singleton continuous field to the obs
metadata for pbcm3k.cxg?
Co-authored-by: atarashansky <[email protected]>
Co-authored-by: atarashansky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but please wait for Alec's review on business logics, since I feel that I don't have enough context to form an opinion there 😆 🙏
Thank you!
#615
Adds redux state and handling logic in histogram component to remove fields if the anno matrix is not a view and the field contains a single value for all obs.
To test:
copy the test dataset to
example-dataset/
:navigate to the dataset
you should not see
donor_BMI_at_collection
in the LSB, but rather the dataset drawer