Fix #51 -- Address two issues with handling of rename operations. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
commented
Jan 24, 2025
syzygy/operations.py
Outdated
Comment on lines
327
to
333
| # XXX: Explicitly define the signature as migration serializer rely on | ||
| # __init__ introspection to assign the kwargs. | ||
| def __init__(self, model_name, old_name, new_name, stage): | ||
| super().__init__( | ||
| model_name=model_name, old_name=old_name, new_name=new_name, stage=stage | ||
| ) | ||
|
|
There was a problem hiding this comment.
I was thinking of taking advantage of PEP-0362 by implementing a StagedOperation.__init_subclass__ that sets an __init__.__signature__ but I figured this was less arcane.
There was a problem hiding this comment.
For reference here's what it would look like 26ad4fb.
Definitely not worth the complexity tradeoff IMO.
charettes
force-pushed
the
rename-issues
branch
from
b208479 to
c4a347b
Compare
charettes
force-pushed
the
rename-issues
branch
2 times, most recently
from
a8b6fa8 to
bc15a0d
Compare
charettes
force-pushed
the
rename-issues
branch
from
bc15a0d to
8eca336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.