Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Screen / Character Hover #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Konsttakis
Copy link

Changed character hover so when one is hovered over the others don't change in size.

Centered logo in home screen and changed hovers so when someone hovers on one the other don't change in size. Also hid scrollbar so it doesn't change other container's size randomly
Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thank you very much!
I didn't understand what you have change I still see that all the characters change the size.

Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Konsttakis I see that the characters still change size. Maybe you didn't upload the right code?
Can you please check this?
Thank you so much!
Best regards,
Chavi

@Konsttakis
Copy link
Author

First of all thank you very much! I didn't understand what you have change I still see that all the characters change the size.

Thank you for reviewing my changes and sorry for the mishap. I think now the changes are implented and take effect.

@Konsttakis Konsttakis requested a review from chavi362 January 3, 2024 15:32
Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The all characters still change size when hovering on one

@Konsttakis
Copy link
Author

The all characters still change size when hovering on one

When you hover over the first one for example the others don't change in size and neither does the background. Before, when you hovered over the first one for example the others also changed and moved so it seemed cluttered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants