Skip to content

Commit

Permalink
typescript 5.3, require Node 20 (#126)
Browse files Browse the repository at this point in the history
  • Loading branch information
carlansley authored Nov 28, 2023
1 parent 478d6a3 commit 6a5d4a4
Show file tree
Hide file tree
Showing 7 changed files with 536 additions and 486 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [20.x, 21.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
name: Branch Build
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [20.x, 21.x]
steps:
- uses: actions/checkout@v3
with:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
jobs:
publish:
runs-on: ubuntu-latest
permissions:
contents: read
id-token: write
name: Publish to NPM
steps:
- uses: actions/checkout@v3
Expand All @@ -19,8 +22,8 @@ jobs:
- name: Audit Signatures
run: npm audit signatures
- name: Run Test
run: npm run ci:test
run: npm run test
- name: Publish
run: npm publish
run: npm publish --provenance
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_PUBLISH }}
4 changes: 3 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ module.exports = {
},
rules: {
'no-shadow': 'off',
'@typescript-eslint/strict-boolean-expressions': 'error',
'@typescript-eslint/no-shadow': 'error',
'@typescript-eslint/no-unused-vars': [
'error',
Expand Down Expand Up @@ -90,7 +91,7 @@ module.exports = {

// turn on node-specific stylistic rules
'n/exports-style': 'error',
'n/no-restricted-import': ['error', ['moment', 'clone', 'fclone', 'lodash', 'underscore']],
'n/no-restricted-import': ['error', ['moment', 'clone', 'fclone', 'lodash', 'underscore', 'fs-extra']],
'n/no-process-env': 'error',
'n/no-sync': 'error',
'n/prefer-global/buffer': 'error',
Expand Down Expand Up @@ -306,6 +307,7 @@ module.exports = {
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
'@typescript-eslint/no-confusing-void-expression': 'off',
'@typescript-eslint/strict-boolean-expressions': 'off',
'@typescript-eslint/unbound-method': 'off',
'n/no-process-env': 'off',
'sonarjs/no-duplicate-string': 'off',
Expand Down
Loading

0 comments on commit 6a5d4a4

Please sign in to comment.