Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint-plugin-sonarjs to 1.0.4 #156

Merged
merged 1 commit into from
Jul 25, 2024
Merged

update eslint-plugin-sonarjs to 1.0.4 #156

merged 1 commit into from
Jul 25, 2024

Conversation

carlansley
Copy link
Contributor

@carlansley carlansley commented Jul 24, 2024

Fixes #155

Saw 1.0.4 was released today, noticed in the README that you have to change the name of the plugin ruleset to plugin:sonarjs/recommended-legacy to use 1.x with eslint 8.x.

@carlansley carlansley self-assigned this Jul 24, 2024
Copy link

Beta Published - Install Command: npm install @checkdigit/[email protected]

@carlansley carlansley requested review from xasmx and le-cong July 24, 2024 19:18
Copy link
Contributor

@le-cong le-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@xasmx xasmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

✅ PR review status - All reviews completed and approved!

@carlansley carlansley merged commit a0e36d0 into main Jul 25, 2024
8 of 9 checks passed
@carlansley carlansley deleted the sonar-1.x branch July 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade sonar plugin to 1.x
3 participants