Fix validation tests

checkdigit · Jan 23, 2025 · b2e9cea · b2e9cea
1 parent a326ba9
commit b2e9cea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/validate-npm-package/validate-npm-package.spec.ts b/src/validate-npm-package/validate-npm-package.spec.ts
@@ -25,10 +25,11 @@ describe('validate-npm-package', () => {
     await verifyNpmPackage();
   }, 300_000);
 
-  // this test should reject but isn't now
-  // this did work historically
-  // eslint-disable-next-line jest/no-disabled-tests
-  it.skip('bad npm package results in error', async () => {
+  // Test uses a bad version of approval package
+  // and requires skipLibCheck: false in tsconfig.json
+  // we set it manually in validate npm package as
+  // checkdigit/typescript-config is various versions of this setting
+  it('bad npm package results in error', async () => {
     actionsCoreSpy.mockImplementationOnce((name) => {
       if (name === 'betaPackage') {
         return '@checkdigit/[email protected]';

diff --git a/src/validate-npm-package/validate-npm-package.ts b/src/validate-npm-package/validate-npm-package.ts
@@ -63,6 +63,9 @@ async function generateProject(workFolder: string, packageJson: PackageJson): Pr
   // create tsconfig.json
   const tsconfigJson = {
     extends: '@checkdigit/typescript-config',
+    compilerOptions: {
+      skipLibCheck: false,
+    },
   };
   await fs.writeFile(`${workFolder}/tsconfig.json`, JSON.stringify(tsconfigJson, null, 2));
 }