WIP: explore d3 library #605
Draft
+2,481
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balzdur
commented
Nov 25, 2024
Comment on lines
+164
to
+167
| .range([ | ||
| height - (numberOfOutcomes - 1) * gap - margin.bottom, | ||
| margin.top, | ||
| ]), |
There was a problem hiding this comment.
This weird computation is required to handle the "gaps" between each part of the stack. This depends on each stack so we need to compute an yScale per stack.
Comment on lines
+192
to
+198
| <use | ||
| href={`${iconsSVGSpriteHref}#arrow-right`} | ||
| height={40} | ||
| width={40} | ||
| x={(width + margin.left - margin.right - 40) / 2} | ||
| y={(height + margin.top - margin.bottom - 40) / 2} | ||
| /> |
There was a problem hiding this comment.
Reuse of an existing svg icon (it's the abstracted SVG code hidden inside Icon component)
Comment on lines
+123
to
+137
| const foo = d3.index( | ||
| data, | ||
| (d) => d.version, | ||
| (d) => d.outcome, | ||
| ); | ||
|
|
||
| // Determine the series that need to be stacked. | ||
| const series = d3 | ||
| .stack<[string, d3.InternMap<Outcome, Data['nodes'][number]>], Outcome>() | ||
| .offset(d3.stackOffsetExpand) | ||
| .keys(orderredOutcomes) | ||
| .order(d3.stackOrderNone) | ||
| .value(([, D], key) => { | ||
| return D.get(key)?.count ?? 0; | ||
| })(foo); |
There was a problem hiding this comment.
This is the strength of D3 (but also the reason it's difficult to understand).
d3.stack() is exactly what we need here, but to make use of it, it's better to use the D3 internal data manipulation fonctions, (like d3.index) and the data structure is not something usual (take some time to reason about).
balzdur
force-pushed
the
thomas/explore-d3
branch
from
7a83975 to
2361261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoC of D3 to handle the testrun charts display.
In this PR :
http://localhost:3000/d3page with hardcoded data