Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Licensing & Feature Access Check #641

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

carere
Copy link
Contributor

@carere carere commented Dec 19, 2024

No description provided.

@carere carere marked this pull request as ready for review January 9, 2025 22:16
@carere carere requested a review from a team January 9, 2025 22:16
Copy link
Contributor

@Pascal-Delange Pascal-Delange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to blind approve most parts of this PR, as it's massive with quite some boilerplate. (I read some parts which seemed more impactful)
A little checklist of questions and other input.

  • with this, we can remove the license key on the frontend, right ? If so, let's remove the code where it's read
  • I remember now that ideally we wanted ideally to mark the paid features for self-hosted customers in "paid" mode (AKA highlight that they're not available in OSS mode) - this is not directly related to this PR, other than in the sense that it's now easy to pilot display changes on the frontend by tweaking the backend endpoint - but let's make a small change to the backend endpoint next week so that it returns at least "test" for everything if the user has the firebase emulator enabled. And while we're at it, ideally mark as "locked" the features that necessitate some setup that isn't done (convoy env variables, etc). The point being: maybe a last good thing in this PR to do is a forth option in feature access (along available, restricted, test) to show a feature that's available in principle but is missing dependencies. Then we can pilot the display from the backend
  • FYI, the links for the doc: rule snoozing, workflows, webhooks. No doc page exists yet for user roles, test run, sanctions, analytics so let's not display a link (just the "upgrade" link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants