-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Licensing & Feature Access Check #641
Open
carere
wants to merge
15
commits into
main
Choose a base branch
from
feature/improve-feature-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,335
−922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to blind approve most parts of this PR, as it's massive with quite some boilerplate. (I read some parts which seemed more impactful)
A little checklist of questions and other input.
- with this, we can remove the license key on the frontend, right ? If so, let's remove the code where it's read
- I remember now that ideally we wanted ideally to mark the paid features for self-hosted customers in "paid" mode (AKA highlight that they're not available in OSS mode) - this is not directly related to this PR, other than in the sense that it's now easy to pilot display changes on the frontend by tweaking the backend endpoint - but let's make a small change to the backend endpoint next week so that it returns at least "test" for everything if the user has the firebase emulator enabled. And while we're at it, ideally mark as "locked" the features that necessitate some setup that isn't done (convoy env variables, etc). The point being: maybe a last good thing in this PR to do is a forth option in feature access (along available, restricted, test) to show a feature that's available in principle but is missing dependencies. Then we can pilot the display from the backend
- FYI, the links for the doc: rule snoozing, workflows, webhooks. No doc page exists yet for user roles, test run, sanctions, analytics so let's not display a link (just the "upgrade" link)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.