Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change tailwind css colors to fit with figma #651

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

refactor: change tailwind css colors to fit with figma #651

wants to merge 9 commits into from
+944 −939

Conversation

ChibiBlasphem
Copy link
Contributor

This PR is divided in 3 parts:

  • 1st commit: Add figma colors as new colors suffixed with figma to ensure no naming conflict while replacing
  • All subsequents commits - to before last: Each commit replace all occurrences of colors with the corresponding figma color
  • Last commit: Remove all old colors and figma suffixes

@ChibiBlasphem ChibiBlasphem requested a review from a team January 13, 2025 14:32
Pascal-Delange
Pascal-Delange approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Pascal-Delange Pascal-Delange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of that chore !
what's your feeling about all those colors in the div classes and such ? Is it an issue in the long term ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pascal-Delange Pascal-Delange Pascal-Delange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChibiBlasphem @Pascal-Delange