Deindent notes shortcodes #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
✅ Deploy Preview for chef-web-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.InnerDeindentmethod handles indented text in a markdown page so that it renders properly.The previous method (
.Inner) could lead to weird HTML rendering when a shortcode is indented in a markdown page and the text it wraps is also indented.See the relevant discussion on Hugo Discourse.
This also cleans up the foundation_tab shortcodes and deletes two shortcodes we don't use.
Definition of Done
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]
Related PRs
Check List