Upgrade RuboCop to 1.69 + enable new cops #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames per rubocop/rubocop#7468 Signed-off-by: Tim Smith <[email protected]>
See rubocop/rubocop#7813 Signed-off-by: Tim Smith <[email protected]>
These were renamed in rubocop/rubocop#7460 Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Renamed in rubocop/rubocop#4864 Signed-off-by: Tim Smith <[email protected]>
Renamed in rubocop/rubocop#3226 Signed-off-by: Tim Smith <[email protected]>
These were renamed in rubocop/rubocop#6983 Signed-off-by: Tim Smith <[email protected]>
Renamed in rubocop/rubocop#3797 Signed-off-by: Tim Smith <[email protected]>
This one was partially updated at some point, but is not right: See https://github.com/rubocop/rubocop/blob/e12b51389500da8e744730f8fa022d739ba0b573/config/obsoletion.yml#L45 Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
This is the latest release Signed-off-by: Tim Smith <[email protected]>
Keep cookstyle at the earlier version so people can migrate off older chef client releases Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
tas50
added a commit
to test-kitchen/test-kitchen
that referenced
this pull request
Dec 7, 2024
These are the fixes discovered by upgrading to RuboCop 1.69 + enabling new cops here: chef/cookstyle#984 Signed-off-by: Tim Smith <[email protected]>
johnmccrae
reviewed
Dec 9, 2024
johnmccrae
reviewed
Dec 9, 2024
johnmccrae
reviewed
Dec 9, 2024
| Style/RedundantCurrentDirectoryInPath: | ||
| Enabled: true | ||
|
|
||
| # Use strings instead of regex with common helper methods |
There was a problem hiding this comment.
This appears to be a dupe of the block starting at line 727?
There was a problem hiding this comment.
Some of the checks are the same for cookstyle vs. chefstyle so they're duplicated in both configs
johnmccrae
reviewed
Dec 9, 2024
| Style/YAMLFileRead: | ||
| Enabled: true | ||
|
|
||
| # You can't have the same named group in a gemfile twice |
There was a problem hiding this comment.
this is a dupe of the block starting at line 735
johnmccrae
reviewed
Dec 9, 2024
config/cookstyle.yml
Outdated
| Bundler/DuplicatedGroup: | ||
| Enabled: true | ||
|
|
||
| # Avoid creating and array and interating into it when .map can be used |
There was a problem hiding this comment.
There's a bunch of duplicates in here. Is this supposed to be like that?
|
Tim, I approved the other PR but I have some questions inline about this one - some of the cops appear to be duplicates of each other - the block starting around line 720 appears to be duplicated in a block at ~line 3531 or so? There's a couple of small typos that need clarifying too. |
Signed-off-by: Tim Smith <[email protected]>
damacus
pushed a commit
to test-kitchen/test-kitchen
that referenced
this pull request
Dec 10, 2024
These are the fixes discovered by upgrading to RuboCop 1.69 + enabling new cops here: chef/cookstyle#984 Signed-off-by: Tim Smith <[email protected]>
|
Related to: #984 |
Resolves a big pile of bugs Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up from #981 so that needs to get merged first