Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDIT: Heavy duty endpoints #65

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

kodaline
Copy link
Contributor

@kodaline kodaline commented Dec 3, 2023

Description

Memory, LLM/Embedder settings and Plugins now are sync and wait until operation is not performed.

Relates to issue #60

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

- added directives folder to store custom directives
- added vlock directive to be used to lock UI for heavy duty endpoints
- added storeRouteMapping to get the current store from the route name
in App.vue
- added custom directive in main.ts

todo: add css style in main.css v-lock class for spinner/overlay
- added directive vLock
- added storeRouteMapping to map stores to routes
- fixed small bug in wipe memory component
- memory, llm/embedding settings and plugins now are sync
and wait until operation is not performed

relates to issue cheshire-cat-ai#60
@kodaline kodaline changed the title Heavy duty endpoints EDIT: Heavy duty endpoints Dec 3, 2023
src/directives/vLock.ts Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
@@ -163,4 +163,8 @@ body {

.apexcharts-series-scatter {
cursor: pointer;
}

.vlock {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid creating a class just for one CSS property, add it directly inside the directive hooks

src/main.ts Outdated Show resolved Hide resolved
@zAlweNy26
Copy link
Member

Do you want to fix the last thing?

@kodaline
Copy link
Contributor Author

kodaline commented Dec 4, 2023

Do you want to fix the last thing?

Do you mean the one to add the CSS property directly to the directive hooks?

@zAlweNy26
Copy link
Member

Do you want to fix the last thing?

Do you mean the one to add the CSS property directly to the directive hooks?

Yes

added css property directly to the directive hook without creating
single property CSS class
@pieroit
Copy link
Member

pieroit commented Dec 6, 2023

Sync endpoints are already in develop on core.
Ping me if you want to make some tests, so we move to main at the same moment

@zAlweNy26 zAlweNy26 merged commit 2ca0334 into cheshire-cat-ai:develop Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants