Preserve hash when computing path from url

.changeset/rude-boats-hammer.md

@@ -0,0 +1,5 @@
+---
+"@chialab/synapse": patch
+---
+
+Preserve hash when computing path from url

.github/workflows/pr.yml

@@ -58,6 +58,9 @@ jobs:
       - name: Install project dependencies
         run: yarn install
 
+      - name: Install browsers
+        run: yarn playwright install
+
       - name: Run tests
         run: yarn test:browser --coverage
 

src/Router/Pattern.ts

@@ -104,7 +104,7 @@ export class Pattern {
      * @returns False if does not match, grouped values if it does.
      */
     matches(path: string): RequestParams | false {
-        path = path.split('?')[0];
+        path = path.split('#')[0].split('?')[0];
         if (this.cache[path]) {
             return this.cache[path];
         }

src/Router/Router.ts

@@ -313,7 +313,7 @@
     async navigate(
         path: Path | string,
         init?: RequestInit,
         data: any = null,
         trigger = true,
         force = false,
         parentRequest?: Request,
@@ -380,7 +380,7 @@
     async replace(
         path: Path | string,
         init?: RequestInit,
         data: any = null,
         trigger = true,
         parentRequest?: Request,
         parentResponse?: Response
@@ -588,7 +588,7 @@
             return null;
         }
         const path = new Path(pathname.replace(this.base, ''));
-        return `${path.pathname}${path.search}`;
+        return `${path.pathname}${path.search}${path.hash?.length > 1 ? path.hash : ''}`;
     }
 
     /**

test/Router.spec.js

@@ -25,13 +25,21 @@ describe('Router', () => {
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('/base/')).toBe('/');
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('/base/?query')).toBe('/?query');
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('/base/path')).toBe('/path');
+        expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('/base/path#hash')).toBe('/path#hash');
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('/base/path?query')).toBe(
             '/path?query'
         );
+        expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('/base/path?query#hash')).toBe(
+            '/path?query#hash'
+        );
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('http://local/base')).toBe('/');
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('http://local/wrong')).toBeNull();
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('http://wrong/base')).toBeNull();
         expect(new Router({ origin: 'http://local', base: '/base' }).pathFromUrl('http://wrong')).toBeNull();
+        expect(new Router({ origin: 'http://local', base: '/base#' }).pathFromUrl('/base#/hash')).toBe('/hash');
+        expect(new Router({ origin: 'http://local', base: '/base#' }).pathFromUrl('/base#/hash?query')).toBe(
+            '/hash?query'
+        );
     });
 
     test('should resolve a path', () => {