Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported python to 3.9 #71

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Update minimum supported python to 3.9 #71

merged 4 commits into from
Jun 25, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Jun 24, 2024

Python 3.8 is reaching end-of-life in October. I think we're OK to update this one, but we should be careful with deploying since some machines might be running python <= 3.8

@ljgray ljgray marked this pull request as ready for review June 24, 2024 23:57
@ljgray ljgray requested review from ketiltrout and rikvl June 24, 2024 23:58
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate a bit about this because of ch_util's heavy use in the acquisition system, but I think it's still probably reasonable.

@ketiltrout
Copy link
Member

Given that ch_util is going to pull in caput anyways, keeping this one at 3.8 isn't going to help us much if we're re-deploying stuff.

@ljgray
Copy link
Contributor Author

ljgray commented Jun 25, 2024

That's a good point about caput (and driftscan). I guess we should review exactly where these repos are being used and see where we can update python

@ljgray ljgray merged commit c460b37 into master Jun 25, 2024
4 checks passed
@ljgray ljgray deleted the ljg/min-v-3.9 branch June 25, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants