feat(hfbcat): Move get_doppler_shifted_freq from ephemeris #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't going to go with the rest of the ephemeris code to the new repository, so let's put is somewhere else. Weirdly, the original docstring for this function seems to indicate it was meant to go in `tools`, but since its hardcoded to work work only on the `HFBCatalog` putting it in `hfbcat` directly seems most intuitive. The re-constituted stub in `ephermis` avoids the circular import. Changes to other files are from `black`.
ketiltrout
force-pushed
the
move_get_doppler_shifted_freq
branch
from
9a7e89c to
1b7db72
Compare
rikvl
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Looks good. I did a quick test and the function works as expected.
Thanks for fixing the docstring. I guess the function was developed in tools and I forgot to update the docstring when Richard recommended to put it in ephemeris.
I'm happy to leave get_range_rate in ephemeris.
arashcosmology
approved these changes
Jul 20, 2024
I figured it must have been something like that.
I am, too. It seems generic enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't going to go with the rest of the ephemeris code to the new repository, so let's put is somewhere else.
Weirdly, the original docstring for this function seems to indicate it was meant to go in
tools, but since its hardcoded to work work only on theHFBCatalogputting it inhfbcatdirectly seems most intuitive.The re-constituted stub in
ephermisavoids the circular import.