Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category table for DataFlagOpinions #16

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Category table for DataFlagOpinions #16

merged 3 commits into from
Mar 14, 2024

Conversation

jrs65
Copy link
Collaborator

@jrs65 jrs65 commented Mar 13, 2024

  • fix: upgrade versioneer for Python 3.12 support
  • feat: add categories for dataflag opinions

@jrs65 jrs65 requested a review from ketiltrout March 13, 2024 22:23
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For efficiency, the primary key in the M-to-M table should be the row itself. It also has the nice side-effect of preventing unintentional duplication.

jrs65 added 2 commits March 13, 2024 18:27
This table is currently empty so changing the schema like this is fine.
@jrs65 jrs65 requested a review from ketiltrout March 14, 2024 01:30
@jrs65 jrs65 merged commit 83fb3ca into master Mar 14, 2024
2 checks passed
@jrs65 jrs65 deleted the category-table branch March 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants