generated from chingu-voyages/voyage-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the main branch with the latest development branch #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions card gives users all the steps they need to prepare their chosen recipe.
…Details page Italic description, proper rendition of image on tablet vs. mobile, proper sizing of video on mobile, hide topic title when no topics are available, hide tags related to equipment from "filed under" tag list, make the description title word break more natural
…ile and tablet Added responsive sizing for text stroke
…n-small-screens Fix thick heading stroke on small screens
…il-page Ch 10 fill out recipe detail page
Add Favorites page that displays all favorited recipes. CH-78
Add Favorites object to navLinks. CH-78
…page Add Favorites feature to the recipe details page. CH-78
Add Favorites page route. CH-78
Improve styling of mobile menu CH-82
Remove unnecessary commented out code. CH-82
The recipe list now supports filtering by tags. This was achieved by adding a new state variable for the selected tag and a new effect to update the URL when the selected tag changes. The tags are fetched from the recipes and stored in a new state variable. The recipes are then filtered based on the selected tag. This feature enhances the user experience by allowing them to narrow down the list of recipes based on specific tags.
…style Ch 82 improve mobile menu style
…feature Ch 78 add favorite recipe feature
…trition information A new NutritionSection component was added to display nutrition information for each recipe, providing users with more detailed information about the nutritional content of the recipes.
The text shadow on headings with transparent text and gradient backgrounds darkened the text 25%. This simple fix adds a css brightness filter to offseet this effect.
…lay a message none is available This change was made to improve the user experience. Now, when there is no nutritional information available for a recipe, a message is displayed to the user instead of leaving the section blank. This provides a better understanding for the user about the absence of nutritional information.
Modified avatar image size. CH-95
Add avatar image file for Darrick. CH-95
Add avatar image file for Grey. CH-95
Add avatar images & info for Darrick & Grey. CH-95
Looks good to me.
A new file, tips.js, has been added to the API directory. This file contains a function to fetch tips from the Tasty API. This function is asynchronous and uses axios to make a GET request to the Tasty API. The function takes in three parameters: id, from, and size, with default values for from and size. The function returns the data received from the API or logs an error if the request fails. This addition will allow the application to fetch and display tips from the Tasty API, enhancing the user experience.
The posts feature was removed from the project as it was no longer needed. This includes all related components, API calls, and utilities. This change simplifies the codebase and reduces the overall size of the project.
A new screenshot file, screenshot-home-dev.png, has been added to the public directory. This image will be used in the documentation to provide a visual representation of the home page in the development environment.
…ng isError and error properties The change was made to improve the readability of the code. By explicitly assigning the properties isError and error, it becomes clearer what values are being returned by the FetchRecipes function. This can help other developers understand the code more quickly and reduce potential confusion.
Greimil
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…ion and instructions The README.md file has been significantly enhanced to provide a more comprehensive overview of the project. This includes a detailed project description, features, technologies used, instructions on how to run the project locally, and information about the team. The changes aim to make the project more accessible and understandable to potential contributors and users. The table of contents has been expanded and restructured for better navigation. The project's features and technologies used have been detailed, and a new section on how to run the project locally has been added. The team section has been updated with the team members' information.
In order to keep the console clean and improve performance in production and other non-development environments, console logging functions have been overridden to do nothing. This change ensures that unnecessary logging does not occur when the NODE_ENV environment variable is set to anything other than "development".
…I_URL variables The .env.example file is added to provide a template for environment variables. This helps new developers to quickly understand the required environment variables for the project. The variables VITE_TASTY_API_KEY and VITE_TASTY_API_URL are included in the template as they are necessary for the application to connect to the Tasty API.
…folders-and-routes-from-file-structure Ch 113 remove post files folders and routes from file structure
…nu-items Ch 111 reorder top nav menu items
…o-recipe-tag-links Ch 112 add hover effect to recipe tag links
feat(recipe details): add graphics to recipe details page
The USE_MIRAGE_API constant was set to false to disable the use of the mirage server for API calls. This change was made to allow the application to make real API calls instead of using the mirage server for testing purposes.
…r-production Turn off mirage server for production
Update layout and content for About page
Update About.jsx
…eadability & layout consistency The CSS classes have been reordered to improve readability and maintainability. The 'min-h-[29rem]' class has been added to the instructions-card to ensure a consistent layout across different screen sizes and prevent layout shifts as content loads.
…eDetails Quick change to the recipe details
joekotvas
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did it! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will update the main branch to the latest version of the development