Eliminate from_u32 with TryFrom<u32>; add todo about set_manifest

drivers/src/dma.rs

@@ -448,7 +448,8 @@ impl<'a> Mmio for &DmaMmio<'a> {
         let offset = src as usize;
         let a = self.dma.read_dword(self.base + offset);
         self.set_error(a.err());
-        T::from_u32(a.unwrap_or_default())
+        // try_into() will always succeed since we only support u32
+        a.unwrap_or_default().try_into().unwrap_or_default()
     }
 }
 

runtime/src/recovery_flow.rs

@@ -48,6 +48,7 @@ impl RecoveryFlow {
         };
         // [TODO][CAP2]: authenticate SoC manifest using keys available through Caliptra Image
         // TODO: switch to ref_from method when we upgrade zerocopy
+        // [TODO][CAP2]: replace this copy with set_manifest
         drivers
             .persistent_data
             .get_mut()

ureg/src/lib.rs

@@ -22,9 +22,8 @@ pub enum UintType {
     U64,
 }
 
-pub trait Uint: Clone + Copy + TryInto<u32> + private::Sealed {
+pub trait Uint: Clone + Copy + Default + TryInto<u32> + TryFrom<u32> + private::Sealed {
     const TYPE: UintType;
-    fn from_u32(val: u32) -> Self;
 }
 
 mod private {
@@ -33,33 +32,21 @@ mod private {
 
 impl Uint for u8 {
     const TYPE: UintType = UintType::U8;
-    fn from_u32(val: u32) -> Self {
-        (val & 0xff) as u8
-    }
 }
 impl private::Sealed for u8 {}
 
 impl Uint for u16 {
     const TYPE: UintType = UintType::U16;
-    fn from_u32(val: u32) -> Self {
-        (val & 0xffff) as u16
-    }
 }
 impl private::Sealed for u16 {}
 
 impl Uint for u32 {
     const TYPE: UintType = UintType::U32;
-    fn from_u32(val: u32) -> Self {
-        val
-    }
 }
 impl private::Sealed for u32 {}
 
 impl Uint for u64 {
     const TYPE: UintType = UintType::U64;
-    fn from_u32(val: u32) -> Self {
-        val as u64
-    }
 }
 impl private::Sealed for u64 {}