Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly CI failing for 1.0.x ROM for stack overflow check #1913

Closed
nquarton opened this issue Jan 27, 2025 · 0 comments · Fixed by #1912
Closed

Nightly CI failing for 1.0.x ROM for stack overflow check #1913

nquarton opened this issue Jan 27, 2025 · 0 comments · Fixed by #1912
Assignees

Comments

@nquarton
Copy link
Contributor

The nightly release process is failing when testing against the 1.0 ROM (1.0.3) because it is tripping the stack overflow detection.

We either need to:

  1. Backport changes that corrected the issue on 1.1/1.2
  2. Disable the check for this test if it is not a security issue.

It was determined this overflow was running into unused space and therefore is not a security threat. No need for an updated 1.0.x ROM was identified, so the course of action is #2 above.

@nquarton nquarton self-assigned this Jan 27, 2025
@nquarton nquarton linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant