Disabling stack overflow check for nightly CI for ROM 1.0.x #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquarton
force-pushed
the
disable_stack_overflow_check_on_1.0_rom_ci
branch
from
9aaf94e to
f7b9319
Compare
nquarton
requested review from
korran,
mhatrevi,
ajisaxena,
swenson and
vsonims
as code owners
jhand2
approved these changes
Jan 27, 2025
jlmahowa-amd
approved these changes
Jan 28, 2025
mhatrevi
approved these changes
Jan 28, 2025
nquarton
force-pushed
the
disable_stack_overflow_check_on_1.0_rom_ci
branch
from
f7b9319 to
e97aeed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.x ROM is failing in the nightly CI for tripping the stack overflow check.
It was confirmed this is not a security issue as this is overflowing into unused space.
This change disables the stack overflow check for nightly CI when testing against ROM 1.0.x only.