Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for upcoming migration to Disable for simulation constructs #4504

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tmckay-sifive
Copy link
Contributor

@tmckay-sifive tmckay-sifive commented Nov 13, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification
  • API deprecation

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Add an option --emit-verif-statement-disable-properties which, when set, will emit cover and SVA-eventually properties to ensure that the Disable for a printf, assert, cover, or assume eventually goes low.

This can be used as one check that these verification statements will not be always Disabled when they are eventually migrated from !reset to Disable.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@tmckay-sifive tmckay-sifive force-pushed the tmckay/sim-construct-disable-warnings branch 2 times, most recently from 571c439 to 06bbd08 Compare December 6, 2024 16:49
Comment on lines +51 to +55
AssertProperty(
prop = ltl.Property.eventually(!disable),
label = Some(s"${label}_never_enabled")
)
CoverProperty(!disable, s"${label}_enabled")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hoping there is a way to give these better messages

@tmckay-sifive tmckay-sifive force-pushed the tmckay/sim-construct-disable-warnings branch from 9e735c8 to b239f48 Compare January 8, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant