Move tests to src/test/scala-2

[adkian-sifive]

We're working on getting tests running with Scala3 with a piecemeal approach, so as features get implemented or the tests get fixed we'll move things back to src/main/scala.

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

• Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Tests moved to scala-2 directory to facilitate smoother Scala 3 development

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
• Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you do one of the following when ready to merge:
  • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
  • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

[jackkoenig]

Several tests fail:

  circtTests.stage.ChiselStageSpec ChiselStage exception handling should include source line and a caret for recoverable errors
  circtTests.stage.ChiselStageSpec ChiselStage exception handling should NOT include source line and caret with an incorrect --source-root
  chiselTests.SourceLocatorSpec (0) Relative source paths (0.a): are emitted by default relative to `user-dir`
  chiselTests.SourceLocatorSpec (2) Module source locators (2.a): modules extending RawModule should have a source locator
  chiselTests.SourceLocatorSpec (2) Module source locators (2.b): modules extending Module should have a source locator
  chiselTests.SourceLocatorSpec (2) Module source locators (2.c): modules extending other user modules should have a source locator
  chiselTests.SourceLocatorSpec (2) Module source locators (2.d): modules extending BlackBox should have a source locator
  chiselTests.SourceLocatorSpec (2) Module source locators (2.e): modules extending ExtModule should have a source locator
  chiselTests.SourceLocatorSpec (2) Module source locators (2.f): user-defined Classes should have a source locator
  chiselTests.SourceLocatorSpec (2) Module source locators (2.g): Inner and anonymous modules should have a source locators
  chiselTests.SourceLocatorSpec (2) Module source locators (2.h): Definitions should have a source locator
  chiselTests.SourceLocatorSpec (3) SourceLocator.makeMessage() (3.a) Should have click-to-source functionality
  chiselTests.stage.WarningConfigurationSpec Warning Configuration should support source filter globs
  chiselTests.simulator.SimulatorSpec Chisel Simulator reports failed expects correctly
  chiselTests.TypeAliasSpec Duplicate bundle type aliases with differing structures should error
  chiselTests.properties.PropertySpec PropertyArithmeticOps should not support expressions in Classes, and give a nice error
  chiselTests.properties.PropertySpec PropertySeqOps should not support expressions in Classes, and give a nice error
  chiselTests.PortSpec Ports now have source locators

Those all probably have hardcoded source locator paths. You can make the tests a little more flexible, but for at least a couple of tests in circtTests.stage.ChiselStageSpec and chiselTests.SourceLocatorSpec we want to make sure we check the full path--it's important that we don't regress here naively updating to Mill 0.12.0 would break this so we need to ensure it's being checked.

[seldridge]

You can make the tests a little more flexible

This may be a good candidate for FileCheck?

[jackkoenig]

@adkian-sifive Same (or perhaps a subset) of tests are still failing

[jackkoenig]

This is currently disabling all tests:

$ ./mill chisel[].test.test
[372/372] chisel[2.13.15].test.test
[372] Run completed in 25 milliseconds.
[372] Total number of tests run: 0
[372] Suites: completed 0, aborted 0
[372] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[372] No tests were executed.
[372/372] ============================== chisel[].test.test ==============================

You can also see this in how the tests run waaaay to fast (taking 4m instead of 20 if you look at post-merge on main).