Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add ability to specify a ref to compare against #4

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This change allows the GitHub action workflow to specify a specific
reference to be used when finding files to send to the language server.

This allows the the languagetool check to use less time by only compare
any new or changed files, instead of running all of the files in the
repository through the language server.

Additional work is needed for repositories after this change is merged.

Motivation and Context

To speed up the processing in large repositories, and not check any files that isn't needed to be checked.

Testing

  1. Tested in one of my own forks.
  2. Not found a way to test it locally.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@AdmiringWorm AdmiringWorm self-assigned this Oct 18, 2023
@AdmiringWorm AdmiringWorm requested a review from pauby October 18, 2023 09:07
@AdmiringWorm AdmiringWorm force-pushed the base-ref branch 5 times, most recently from 1658d7a to 536a181 Compare October 18, 2023 09:22
This change allows the GitHub action workflow to specify a specific
reference to be used when finding files to send to the language server.

This allows the the languagetool check to use less time by only compare
any new or changed files, instead of running all of the files in the
repository through the language server.

Additional work is needed for repositories after this change is merged.
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pauby pauby merged commit aa6afec into chocolatey:develop Feb 12, 2024
8 checks passed
@AdmiringWorm AdmiringWorm deleted the base-ref branch February 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants