[Fix] Add fix for #92: Support class.method as a Tokenizer for CustomEmbedding +. minor changes
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod for token counting
Hyperlink good first issue
- Removed abstractmethod decorators from `embed_batch`, `count_tokens_batch`, and `similarity` methods in the BaseEmbeddings class. - Updated the `similarity` method to ensure it returns a float. - Introduced a new CustomEmbeddings class implementing the abstract methods with functionality for embedding, token counting, and similarity calculation. - Added comprehensive unit tests for the CustomEmbeddings class, covering initialization, embedding single and batch texts, token counting, and similarity calculation. These changes enhance the flexibility and test coverage of the embeddings functionality.
[FIX] Support class methods as `token_counter` objects for `CustomEmbeddings` (#92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements to the
chonkieproject, focusing on enhancing tokenizer handling, updating documentation, and adding new test cases. Below are the most important changes:Enhancements to Tokenizer Handling:
src/chonkie/chunker/base.py: Improved the_get_tokenizer_backend,_get_tokenizer_counter,_encode,_encode_batch,_decode, and_decode_batchmethods to support callable tokenizer backends. [1] [2] [3] [4] [5] [6]__init__method.Documentation Updates:
CONTRIBUTING.md: Fixed numbering issues and added a hyperlink forgood-first-issuelabel. [1] [2] [3]Test Cases:
CustomEmbeddingsclass intests/embeddings/test_custom_embeddings.py.Code Cleanup:
Workflow Update:
.github/workflows/python-test-push.yml: Expanded the matrix of Python versions to include 3.8 and 3.13.