Skip to content

Commit

Permalink
Fix some style issues in Puppet manifests
Browse files Browse the repository at this point in the history
These checks are performed on the Puppet Forge to give quality scores to
modules, and are failing for the choria repositories:
* The `ensure` parameter must be the first one in resource declaration;
* Non-interpolated strings should be single, not double-quoted.

While these changes are gratuitous, they will allow the scoring of the
modules to increase, giving users a more positive view of the care taken
to maintain them.
  • Loading branch information
smortex committed Sep 3, 2024
1 parent 298c043 commit 9f85dba
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions moduleroot/manifests/init.pp.erb
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ class <%= choria_module_name %> (
Hash $server_config = {},
Boolean $client = $mcollective::client,
Boolean $server = $mcollective::server,
Enum["present", "absent"] $ensure = "present"
Enum['present', 'absent'] $ensure = 'present'
) {
mcollective::module_plugin{$name:
ensure => $ensure,
config_name => $config_name,
client_files => $client_files,
server_files => $server_files,
Expand All @@ -48,6 +49,5 @@ class <%= choria_module_name %> (
server_config => $server_config,
client => $client,
server => $server,
ensure => $ensure
}
}

0 comments on commit 9f85dba

Please sign in to comment.