-Use the icon naming scheme Electron wants for auto selected/dark mod…

…e icon state for Mac menu bar icon (Fixes #44) -Update comments
chrisknepper · Jul 17, 2018 · c5af546 · c5af546
1 parent 77b38e9
commit c5af546
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/resources/tray/icon_mac.png → resources/tray/icon_macTemplate.png b/resources/tray/icon_mac.png → resources/tray/icon_macTemplate.png
diff --git a/resources/tray/[email protected] → resources/tray/[email protected] b/resources/tray/[email protected] → resources/tray/[email protected]
diff --git a/src/helpers/tray/tray_manager.js b/src/helpers/tray/tray_manager.js
@@ -37,10 +37,12 @@ export default class TrayManager {
 
   setTrayIconPath() {
     if (IS_WINDOWS) {
-        // Re-use regular app .ico for the tray icon on Windows
+        // Re-use regular app .ico for the tray icon on Windows.
         return path.join(__dirname, '..', 'resources', 'icon.ico');
     } else {
-        const trayIconFileName = IS_MAC ? 'icon_mac.png' : 'icon.png';
+        // Mac tray icon filename MUST end in 'Template' and contain only black and transparent pixels.
+        // Otherwise, automatic inversion and dark mode appearance won't work.
+        const trayIconFileName = IS_MAC ? 'icon_macTemplate.png' : 'icon.png';
         return path.join(__dirname, '..', 'resources', 'tray', trayIconFileName);
     }
   }