Skip to content

Commit

Permalink
[goldmansachs#1] Refactor and fix the index.js file, remove verbose e…
Browse files Browse the repository at this point in the history
…xception names from the error listener
  • Loading branch information
christian0101 committed Jun 21, 2024
1 parent c5c97e1 commit d53415d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion spec/parser/Lexer.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { FEELLexer, ThrowErrorAndFailListener } from "jdmn-js-runtime";

describe("Lexer", () => {
it("testIncorrectToken", () => {
expect(function() { checkToken("@"); } ).toThrow(new Error("line 1:0 token recognition error at: '@' LexerNoViableAltException"));
expect(function() { checkToken("@"); } ).toThrow(new Error("line 1:0 token recognition error at: '@'"));
});

it("testSpaces", () => {
Expand Down
3 changes: 1 addition & 2 deletions src/jdmn-js-runtime/index.node.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import FEELLexer from "./parser/FEELLexer.js";
import FEELParser from "./parser/FEELParser.js";

import { inputEntry } from "./validation/FEELValidation.js";
import { outputEntry } from "./validation/FEELValidation.js";
import { inputEntry, outputEntry } from "./validation/FEELValidation.js";
import { ThrowErrorAndFailListener } from "./validation/ThrowErrorAndFailListener.js";

export default {
Expand Down
5 changes: 2 additions & 3 deletions src/jdmn-js-runtime/index.web.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import FEELLexer from "./parser/FEELParser.js";
import FEELLexer from "./parser/FEELLexer.js";
import FEELParser from "./parser/FEELParser.js";

import { inputEntry } from "./validation/FEELValidation.js";
import { outputEntry } from "./validation/FEELValidation.js";
import { inputEntry, outputEntry } from "./validation/FEELValidation.js";
import { ThrowErrorAndFailListener } from "./validation/ThrowErrorAndFailListener.js";

export default {
Expand Down
5 changes: 3 additions & 2 deletions src/jdmn-js-runtime/validation/ThrowErrorAndFailListener.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import antlr4 from "antlr4";

export class ThrowErrorAndFailListener extends antlr4.error.ErrorListener {
syntaxError(recognizer, offendingSymbol, line, column, msg, e) {
throw new Error(`line ${line}:${column} ${msg} ${e}`);
// eslint-disable-next-line no-unused-vars
syntaxError(recognizer, offendingSymbol, line, column, msg, _) {
throw new Error(`line ${line}:${column} ${msg}`);
}
}

Expand Down

0 comments on commit d53415d

Please sign in to comment.