Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: establish test/util.py and test/test_nmt.py #503

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

erlend-aasland
Copy link
Contributor

Give NMT tests their own file, and establish a util.py for the test
suite for common stuff like the location of sample EDS files.

Give NMT tests their own file, and establish a util.py for the test
suite for common stuff like the location of sample EDS files.
@erlend-aasland
Copy link
Contributor Author

Yak-shave in preparation for #500

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.71%. Comparing base (c413eaf) to head (0905d01).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   67.74%   67.71%   -0.04%     
==========================================
  Files          26       26              
  Lines        3113     3113              
  Branches      527      527              
==========================================
- Hits         2109     2108       -1     
  Misses        864      864              
- Partials      140      141       +1     

see 1 file with indirect coverage changes

@erlend-aasland
Copy link
Contributor Author

Note that the NMT slave test now uses setUp/tearDown iso. their class equivalents, in order to provide a saner environment for the test cases.

@erlend-aasland
Copy link
Contributor Author

Moreover, I removed some dead code.

test/util.py Outdated Show resolved Hide resolved
@acolomb acolomb merged commit 08eba81 into christiansandberg:master Jul 8, 2024
1 check passed
@erlend-aasland erlend-aasland deleted the test/nmt branch July 8, 2024 13:57
@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

@acolomb
Copy link
Collaborator

acolomb commented Jul 8, 2024

Thanks for your continued contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants