[UIA] Expose <legend> as UIA_GroupControlTypeId, not Text

Text elements in UIA should be leaf nodes. <legend> can contain a subtree of text nodes. We are updating the html-aam spec and Chromium to fix this mistake: w3c/html-aam#531. Fixed: 324112189 Change-Id: I1a3b3e7cc7c251bc5653fe35871d8e64a6e0a6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5275269 Reviewed-by: Kurt Catti-Schmidt <[email protected]> Auto-Submit: Benjamin Beaudry <[email protected]> Commit-Queue: Benjamin Beaudry <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257475}
chromium · Feb 7, 2024 · f16b46b · f16b46b
1 parent 06b1146
commit f16b46b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/content/test/data/accessibility/html/fieldset-expected-uia-win.txt b/content/test/data/accessibility/html/fieldset-expected-uia-win.txt
@@ -1,9 +1,9 @@
 Document
 ++Group
 ++++Group Name='Browser Engines:'
-++++++Text IsControlElement=false
+++++++Group IsControlElement=false
 ++++++++Text Name='Browser Engines:'
 ++Group Name='Which cake do you prefer?'
-++++Text IsControlElement=false
+++++Group IsControlElement=false
 ++++++Text Name='Which cake do you prefer?'
 ++++++++Text Name='Which cake do you prefer?' IsControlElement=false
diff --git a/content/test/data/accessibility/html/legend-expected-uia-win.txt b/content/test/data/accessibility/html/legend-expected-uia-win.txt
@@ -1,7 +1,7 @@
 Document
 ++Group
 ++++Group Name='Browser Engines:'
-++++++Text IsControlElement=false
+++++++Group IsControlElement=false
 ++++++++Text Name='Browser Engines:'
 ++++++Text Name='Browser: '
 ++++++Edit

diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc
@@ -1091,7 +1091,7 @@ AXPlatformNodeWin::UIARoleProperties AXPlatformNodeWin::GetUIARoleProperties() {
               L"description"};
 
     case ax::mojom::Role::kLegend:
-      return {UIALocalizationStrategy::kSupply, UIA_TextControlTypeId,
+      return {UIALocalizationStrategy::kSupply, UIA_GroupControlTypeId,
               L"description"};
 
     case ax::mojom::Role::kLayoutTable: