Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: core-crd fluent-bit image to 24.4.2. #247

Closed
wants to merge 2 commits into from

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Apr 19, 2024

Update the fluent-bit image to 24.4.2 to match the default in core-operator.

Update the fluent-bit image to 24.4.2 to match the default in core-operator.

Signed-off-by: Phillip Whelan <[email protected]>
@pwhelan pwhelan requested review from agup006, patrick-stephens, jasmingacic and a team April 19, 2024 18:39
@pwhelan
Copy link
Contributor Author

pwhelan commented Apr 19, 2024

The version check fails, even though I modified it slightly. I cannot modify the actual 'z' part of the version since it tracked by core-operator-release.

https://github.com/chronosphereio/calyptia-charts/actions/runs/8758200174/job/24038480359?pr=247#step:8:42

 ✖︎ core-crd => (version: "2.8.4-r1", path: "charts/core-crd") > chart version not ok. Needs a version bump! 

@patrick-stephens
Copy link
Contributor

Yeah but we cannot release without changing the version as helm releaser will fail.
Typically what we have done in the past is increment the version here and make sure the next operator release increments the next more significant digit.

@patrick-stephens
Copy link
Contributor

So I would go for 2.8.5 then make sure operator goes to 2.9.0

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be done here, it needs to be done via the private repo - see #248.

@jasmingacic
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants