[stateunstable] Add metric-usages-by-metric-name and metric-usages-by-label-name list cmds #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eunstable-metric-usages-by-name-and-label
…eunstable-metric-usages-by-name-and-label
…ic-usages-by-name-and-label
aschepis
reviewed
Sep 5, 2024
aschepis
approved these changes
Sep 5, 2024
|
|
||
| // loop until we've fetched enough results | ||
| for { | ||
| current, token, err := listFn(Page{Size: pageSize, Token: nextToken}) |
There was a problem hiding this comment.
based on what im reading, if i try to send in pageSize == 1 million it will attempt to get 1 million records in a go. does this fail or default to the max allowed in API?
There was a problem hiding this comment.
It will not fail in the API. The max amount of results we see in practice is <20k in most tenants. This API returns about 100k max results for our largest tenant.
There was a problem hiding this comment.
Yeah the BE should be enforcing some max so if PageSize is > that max, or if PageSize == 0, that max is what is used.
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func mockListFn(p Page) ([]string, string, error) { |
There was a problem hiding this comment.
can you add a test that doesn't set Page.Size? let it default to zero.
sidneyw
approved these changes
Sep 5, 2024
rallen090
deleted the
ra/stateunstable-metric-usages-by-name-and-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds chronoctl support for the new unstable state metric usages APIs