Add library for converting prometheus/alertmanager configurations to Chronosphere entities #47
+9,903
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarnes52
force-pushed
the
bgb/prometheusconversion
branch
8 times, most recently
from
cf2f8c8 to
24bc525
Compare
bbarnes52
force-pushed
the
bgb/prometheusconversion
branch
3 times, most recently
from
fd395bd to
386e99a
Compare
prashantv
approved these changes
Jan 8, 2025
| @@ -60,13 +60,11 @@ func TestListRuleEvaluations(t *testing.T) { | |||
| }, | |||
| expected: `rule_slug: slug-one | |||
| rule_type: MONITOR | |||
| detected_at: "1970-01-01T00:00:00.000Z" | |||
There was a problem hiding this comment.
discussed offline, and addressed by pinning strfmt in go.mod. Bug is described in a comment in go.mod, summarizing here for posterity:
// Required to avoid picking up https://github.com/go-openapi/strfmt/commit/b36a4901fcb51dbf4300a5a6b60b4335440aa208
// which causes strfmt.DateTime values to be incorrectly omitted from yaml output due to a bug in the yaml library
// where the IsZero method on pointers that implement the IsZeroer interface is not invoked.
bbarnes52
force-pushed
the
bgb/prometheusconversion
branch
from
386e99a to
2ebbe43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR open sources the core logic used by
chronoctl convert/sync prometheusto convert prometheus and alertmanager configurations to Chronosphere entities. In chronoctl v1, conversion will be performed on the client-side, as opposed to v0, which performs conversion on the server-side.This approach has the following benefits: