Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sc-122908] move log allocation config api from unstable to v1 #100

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[sc-122908] move log allocation config api from unstable to v1 #100

merged 1 commit into from
Feb 3, 2025

Conversation

sophia-hanley
Copy link
Contributor

@sophia-hanley sophia-hanley commented Jan 30, 2025 •
edited
Loading

@sophia-hanley sophia-hanley force-pushed the sophia/1-30/122908 branch 3 times, most recently from 7d675ed to 5a23076 Compare January 31, 2025 00:18
@sophia-hanley sophia-hanley marked this pull request as ready for review January 31, 2025 19:20
@sophia-hanley sophia-hanley requested a review from a team as a code owner January 31, 2025 19:20
aschepis
aschepis requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@aschepis aschepis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there is an issue w/ the CHANGELOG removing the 1.7.0 release (rebase issue perhaps?). once fixed i will approve

CHANGELOG.md
Added:
* Adds support for custom dimension labels in the `chronosphere_slo` resource.

## 1.7.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a rebase issue here since it removes the 1.7.0 release changelog and squashes it into the unreleased

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted offline, all 3 changes should be under unreleased

@sophia-hanley sophia-hanley merged commit 7a91285 into main Feb 3, 2025
4 checks passed
@sophia-hanley sophia-hanley deleted the sophia/1-30/122908 branch February 3, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschepis aschepis aschepis approved these changes

@lwatiker lwatiker Awaiting requested review from lwatiker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophia-hanley @aschepis