⏰ Add td_*seconds serde Serialize and Deserialize functions for TimeDelta
#1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosti007
changed the title
td_*seconds serde Serialize and Deserialize functions for TimeDeltatd_*seconds serde Serialize and Deserialize functions for TimeDelta
djc
reviewed
Jan 17, 2025
| S: ser::Serializer, | ||
| { | ||
| serializer.serialize_i64(td.num_nanoseconds().ok_or(ser::Error::custom( | ||
| "value out of range for a timedelta with nanosecond precision", |
There was a problem hiding this comment.
Let's capitalize TimeDelta in these error messages, too.
There was a problem hiding this comment.
In the timestamp versions of these functions the "timestamp" is also lower cased, hence I did so here too. So I think there are three options:
- Leave them lowercased.
- Uppercase just
timedelta - Uppercase both
What do you prefer?
There was a problem hiding this comment.
Timestamp is an English word commonly spelled as one word. Time delta is not an actual word and is more of a term of art introduced by this library's API. So I think it makes sense to capitalize TimeDelta in these errors even if the same is not true for timestamp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
This PR copy-pastes the current implementation for
DateTimesuch that we have equal implementations forDeltaTime.I opted to add the logic to the existing
serde.rsfile. However, I think this might be the wrong place and a better solution would be to move themain.rs'sserdemodule combined with thisserde.rsfile to a separatesrc/serde.rsfile, thoughts?PS:
I am just doing a drive-by PR on this crate, so I don't really know what the exact requirements are regarding testing ect. Please let me know!