Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated info for SARIEN #140

Merged
merged 5 commits into from
Apr 27, 2024
Merged

Conversation

archisman-panigrahi
Copy link
Contributor

@archisman-panigrahi archisman-panigrahi commented Feb 17, 2024

Updated info for SARIEN Chromebook.

Full UEFI is not supported in this Chromebook, but everything I tested works under RW_Legacy firmware with Linux Mint 22.3.

This Chromebook has upgradable RAM and SSD, but I am not sure whether that too should be added to the notes.

meghan06
meghan06 previously approved these changes Mar 31, 2024
Copy link
Member

@meghan06 meghan06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanaobrien Looks good to me

@archisman-panigrahi
Copy link
Contributor Author

archisman-panigrahi commented Mar 31, 2024

Just wanted to clarify that the speaker and mic work out-of-the box without requiring the audio script by WeirdTreeThing.

Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Could be slimmed down

@ninelore
Copy link
Member

also link broken

@archisman-panigrahi
Copy link
Contributor Author

@ninelore I fixed the link and trimmed it down a little bit.

@ninelore
Copy link
Member

Still very long imo. I'd cut it down to what not works.

@WeirdTreeThing could you integrate the sarien keymap into cros-keyboard-map? Maybe we can leave out the keyd part altogether

@archisman-panigrahi
Copy link
Contributor Author

I cut it down. I will wait for WeirdTreeThing's reply.

@WeirdTreeThing
Copy link
Member

Still very long imo. I'd cut it down to what not works.

@WeirdTreeThing could you integrate the sarien keymap into cros-keyboard-map? Maybe we can leave out the keyd part altogether

Sure

@WeirdTreeThing
Copy link
Member

It has been added to the script now

@archisman-panigrahi
Copy link
Contributor Author

Check it now.

Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ninelore ninelore requested a review from meghan06 April 16, 2024 16:03
@ninelore ninelore merged commit 211d075 into chrultrabook:main Apr 27, 2024
1 check passed
@archisman-panigrahi archisman-panigrahi deleted the patch-1 branch April 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants