Drop Python 3.8 #323
Merged
Drop Python 3.8 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
=======================================
Coverage 75.37% 75.37%
=======================================
Files 5 5
Lines 268 268
=======================================
Hits 202 202
Misses 66 66 ☔ View full report in Codecov by Sentry. |
ruff check . --select ALL --fix --unsafe-fixes --preview --show-fixes --ignore T201 --ignore PT014 --ignore RUF100; ruff format .;
Fixed 9 errors:
- docs/conf.py:
6 × UP006 (non-pep585-annotation)
- src/cihai_cli/cli.py:
1 × UP006 (non-pep585-annotation)
- tests/conftest.py:
2 × RUF052 (used-dummy-variable)
Found 59 errors (9 fixed, 50 remaining).
7 files left unchanged
tony
force-pushed
the
remove-python-3.8
branch
2 times, most recently
from
def0312 to
2a73182
Compare
tony
force-pushed
the
remove-python-3.8
branch
from
2a73182 to
196a2d9
Compare
tony
force-pushed
the
remove-python-3.8
branch
from
196a2d9 to
b3844f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Python 3.8 reached end-of-life on October 7th, 2024 (see devguide.python.org, Status of Python Versions, Unsupported versions)
Changes
Drop Python 3.8
Ruff fixes via ruff 0.8.4
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .cihai: Bump minimum version to 0.35.0 (#323)
Requires Python 3.9.
Updates unihan-etl to 0.37.0, which also requires Python 3.9.