Skip to content

Commit

Permalink
feat: Add SingleOwnerMSCA proxy veification artifacts and instructions (
Browse files Browse the repository at this point in the history
#37)

## Summary

Add proxy verification instructions and verification artifacts for
`SingleOwnerMSCA` accounts. A corresponding PR will be added to the
`master` branch.

## Detail

ETH-SEPOLIA verification was already done by @huaweigu. The remaining
chains were verified directly following the instructions added in the
README in this PR:

-
https://sepolia.arbiscan.io/address/0xc68c3867b9b22b7291d8644f7742b29781bbe05f#readProxyContract
-
https://amoy.polygonscan.com/address/0x55907b59a2c4cd855ec140a43da8e35641a8a4e2#readProxyContract
-
https://polygonscan.com/address/0x7609b25a38bbccef4369c3f25fffe9be0d98ba31#readProxyContract
-
https://arbiscan.io/address/0x7dcd373b7116bf3db6633d779805c4acd9648ed5#readProxyContract
-
https://etherscan.io/address/0x9ba84cb7e0723ffe23d22fd165ec09a38e8c7ac0#readProxyContract

### Checklist
- [x] Did you update relevant docs? (docs are found in the `docs`
folder)
- [x] Do your commits follow the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [x] Does your PR title also follow the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?

## Testing

A sanity test checking that new contracts would get automatically
verified was done on this wallet:
<https://amoy.polygonscan.com/address/0x3b89d50ff795fa7788815a5747a4a5c0afd9190f#code>
  • Loading branch information
ashutosh-ukey authored Oct 30, 2024
1 parent 7ef2651 commit 2c50346
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,15 @@ For running integration tests in Anvil node, run `make anvil-tests`. This runs t
# Example
cast abi-encode "constructor(address,address,uint256)" "0x0166EA90E565476f13c6a0D25ED2C35599E58785" "0x0000000071727De22E5E9d8BAf0edAc6f37da032" 18
```

Make sure to save this output under `script/verify/<ContractName>/abiEncodedConstructorArgs`.
Tip: if your contract's constructor arguments have complicated types, you can get this value instead by `console.log`ing the output of `abi.encode(arg1, arg2, ...)` in Solidity.

* For account factory contracts, you may also need to manually verify the proxy contract. To do this, you will first need to create an account using the account factory, and follow the above strategy. After verifying one account, all subsequent proxies should be automatically detected.

Tip: analyze the account creation function on the factory (e.g. `createAccount` for `SingleOwnerMSCAFactory`) to deduce the constructor arguments for the proxy deployment when trying to verify it on a block explorer.

* Click verify and publish

### Deployment Metadata
Expand Down
Loading

0 comments on commit 2c50346

Please sign in to comment.