Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate the latest updates #54

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

huaweigu
Copy link
Contributor

@huaweigu huaweigu commented Dec 17, 2024

Summary

Align with the latest developments from the private repository circlefin:entry-point-v0.6.

Detail

Changeset

  • resolve all compiler warnings and enable deny_warnings moving forward
  • address all reported findings from the second audit conducted by CS

Checklist

  • Did you add new tests and confirm all tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the docs folder)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint) and fix any issues?
  • Did you run formatter (yarn format:check) and fix any issues (yarn format:write)?

Testing

  • tests have been added to validate the audit fixes

Documentation

n/a

@@ -1,44 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,54 +0,0 @@
/*
* Copyright 2024 Circle Internet Group, Inc. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,44 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,444 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,189 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,512 +0,0 @@
/*
* Copyright 2024 Circle Internet Group, Inc. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,190 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,45 +0,0 @@
## Weighted Multisig Plugin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,529 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@@ -1,121 +0,0 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not apply to this branch.

@huaweigu huaweigu marked this pull request as ready for review December 17, 2024 17:45
@huaweigu huaweigu merged commit 194a8e9 into circlefin:entry-point-v0.6 Dec 17, 2024
6 checks passed
@huaweigu huaweigu deleted the chore/sync-up branch December 17, 2024 21:28
@huaweigu huaweigu mentioned this pull request Dec 18, 2024
7 tasks
huaweigu added a commit that referenced this pull request Dec 18, 2024
## Summary
So it'd make the migration easy. For more details, please refer to
natspec.

## Detail
### Changeset
* reverted one change from the [previous
PR](#54)

### Checklist
- [x] Did you add new tests and confirm all tests pass? (`yarn test`)
- [x] Did you update relevant docs? (docs are found in the `docs`
folder)
- [x] Do your commits follow the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [x] Does your PR title also follow the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [ ] If you have a breaking change, is it [correctly reflected in your
commit
message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g.
`feat!: breaking change`)
- [x] Did you run lint (`yarn lint`) and fix any issues?
- [x] Did you run formatter (`yarn format:check`) and fix any issues
(`yarn format:write`)?

## Testing
* test has also been reverted

## Documentation
* see natspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants