comment

cisagov · Jan 27, 2025 · decd14b · decd14b
1 parent a377b12
commit decd14b
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 7 deletions.
diff --git a/.github/workflows/build_sign_release.yaml b/.github/workflows/build_sign_release.yaml
@@ -70,7 +70,6 @@ jobs:
           echo "KeyVaultCertificateName=$($KeyVaultInfo.KeyVault.CertificateName)" >> $env:GITHUB_OUTPUT
       - name: Sign Module
         run: |
-          # Source the function.
           . repo/utils/workflow/Build-SignRelease.ps1
           New-ModuleSignature `
             -AzureKeyVaultUrl ${{ steps.key-vault-info.outputs.KeyVaultUrl }} `

diff --git a/.github/workflows/publish_private_package.yaml b/.github/workflows/publish_private_package.yaml
@@ -61,7 +61,6 @@ jobs:
           echo "KeyVaultCertificateName=$($KeyVaultInfo.KeyVault.CertificateName)" >> $env:GITHUB_OUTPUT
       - name: Create Private Gallery
         run: |
-          # Source the function.
           . repo/utils/workflow/Publish-ScubaGear.ps1
           cd repo
           New-PrivateGallery -GalleryName $env:GalleryName -Trusted

diff --git a/.github/workflows/publish_public_package.yaml b/.github/workflows/publish_public_package.yaml
@@ -46,7 +46,6 @@ jobs:
           path: repo
       - name: Install Azure Signing Tool
         run: |
-          # Source the function
           . repo/utils/workflow/Install-AzureSignTool.ps1
           Install-AzureSignTool
       # OIDC Login to Azure Public Cloud with AzPowershell
@@ -67,7 +66,6 @@ jobs:
           echo "KeyVaultCertificateName=$($KeyVaultInfo.KeyVault.CertificateName)" >> $env:GITHUB_OUTPUT
       - name: Sign and Publish Module
         run: |
-          # Source the function.
           . repo/utils/workflow/Publish-ScubaGear.ps1
           # Remove non-release files
           Remove-Item -Recurse -Force repo -Include .git*

diff --git a/Testing/workflow/Build-SignRelease.Tests.ps1 b/Testing/workflow/Build-SignRelease.Tests.ps1
@@ -6,11 +6,10 @@
 Describe "Bad Inputs Check" {
   It "The root folder name should exist" {
     $ScriptPath = Join-Path -Path $PSScriptRoot -ChildPath '../../utils/workflow/Build-SignRelease.ps1' -Resolve
-    # Source the function
     . $ScriptPath
     # The function should throw an exception if the root folder name does not exist.
     { New-ModuleSignature `
-      -AzureKeyVaultUrl "https://www.cisa.gov" `
+      -AzureKeyVaultUrl "https://www.example.com" `
       -CertificateName "certificate name" `
       -ReleaseVersion "0.0.1" `
       -RootFolderName "nonexistantfoldername" } | Should -Throw

diff --git a/Testing/workflow/Install-AzureSignTool.Tests.ps1 b/Testing/workflow/Install-AzureSignTool.Tests.ps1
@@ -2,7 +2,6 @@
 
 BeforeDiscovery {
   $ScriptPath = Join-Path -Path $PSScriptRoot -ChildPath '../../utils/workflow/Install-AzureSignTool.ps1' -Resolve
-  # Source the function
   . $ScriptPath
   Install-AzureSignTool
 }