Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Microsoft.PowerApps.Administration.PowerShell min/max versions #1530

Conversation

schrolla
Copy link
Collaborator

@schrolla schrolla commented Jan 23, 2025

🗣 Description

Updated RequiredVersions.ps1 file to update the Microsoft.PowerApps.Administration.PowerShell minimum and maximum versions to support pinning to versions newer than the bugged 2.0.197 version.

  • Min version set to 2.0.198
  • Max version re-pinned to 2.0.203

💭 Motivation and context

Allows users to use newer working versions of the PowerApps admin module while preventing installation of the 2.0.197 bugged version.

Closes #1409

🧪 Testing

  • Remove existing ScubaGear dependencies from your test machine. Either by running Uninstall-Module for each dependency OR go to your Documents/WindowsPowerShell/Modules folder and delete all ScubaGear dependent modules.
  • Import the ScubaGear module from the feature branch (Import-Module PowerShell/ScubaGear).
  • Run Initialize-ScubaGear
  • Validate that the version of Microsoft.PowerApps.Administration.PowerShell installed is > 2.0.197
  • Run Invoke-SCuBA -p powerplatform and confirm it works as intended

📷 Screenshots (if appropriate)

Example of running Initialize-SCuBA with the updated dependencies in RequiredVersions.ps1
Screenshot 2025-01-23 at 3 18 13 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@schrolla schrolla added the upstream update This issue or pull request pulls in upstream updates label Jan 23, 2025
@schrolla schrolla added this to the Lionfish milestone Jan 23, 2025
@schrolla schrolla self-assigned this Jan 23, 2025
@schrolla schrolla linked an issue Jan 23, 2025 that may be closed by this pull request
3 tasks
@schrolla schrolla requested review from buidav and twneale January 23, 2025 21:22
@schrolla schrolla marked this pull request as ready for review January 23, 2025 21:23
Copy link
Collaborator

@twneale twneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward 🤔👍

Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with v2.0.198 nor v2.0.203 on my end.
Didn't check the in between versions but a little googling show no issues with the other versions. ScubaGear will max install v2.0.203 by default as well anyway.
LGTM.

@schrolla schrolla force-pushed the 1409-update-microsoftpowerappsadministrationpowershell-to-v20200 branch from a661d51 to 7cc125b Compare January 31, 2025 20:33
@schrolla
Copy link
Collaborator Author

@nanda-katikaneni This PR is ready for merge.

* Min version 2.0.0 -> 2.0.198 past 2.0.197 bugged version
* Max version re-pinned to 2.0.203
@schrolla schrolla force-pushed the 1409-update-microsoftpowerappsadministrationpowershell-to-v20200 branch from 7cc125b to 7d4ee60 Compare February 5, 2025 15:44
@nanda-katikaneni nanda-katikaneni merged commit 3dd0987 into main Feb 5, 2025
20 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1409-update-microsoftpowerappsadministrationpowershell-to-v20200 branch February 5, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Microsoft.PowerApps.Administration.PowerShell to v2.0.200
4 participants