Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Gmail Rego #118

Merged
merged 10 commits into from
Dec 22, 2023
Merged

Refactor Gmail Rego #118

merged 10 commits into from
Dec 22, 2023

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Dec 20, 2023

🗣 Description

Refactor Gmail Rego to comply with current style best-practices.

💭 Motivation and context

Closes #116.

🧪 Testing

  • Rego unit tests pass
  • Compared refactored results with results from main -- no difference.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto requested review from rgbrow1949 and snarve December 20, 2023 18:23
@adhilto adhilto self-assigned this Dec 20, 2023
@buidav buidav added this to the Backlog milestone Dec 20, 2023
@adhilto adhilto requested a review from buidav December 21, 2023 21:50
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran .\opa_windows_amd64.exe check --rego-v1 to check for OPA v1 compatibility. The flag is only available for OPA executables greater than 0.59. It came back with only one thing :). Fix before merging. Everything else runs perfectly.

rego/Gmail.rego Outdated Show resolved Hide resolved
Copy link
Collaborator

@snarve snarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: David Bui <[email protected]>
@adhilto adhilto merged commit 2029d92 into main Dec 22, 2023
1 check passed
@adhilto adhilto deleted the rego-refactor branch December 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Gmail Rego
3 participants