Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nick M. <[email protected]>
  • Loading branch information
hillaryj and mcdonnnj authored Nov 16, 2020
1 parent 34f2ae9 commit d7d2e3f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions .github/ISSUE_TEMPLATE/onboarding-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ your onboarding buddy.
- [ ] If you don't already have a GitHub account,
[create a GitHub account with your government email address](https://github.com/join).
- [ ] If you already have a GitHub account, [add your government email address](https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/adding-an-email-address-to-your-github-account).
- [ ] Go through the [FISMA-Ready Github guide](https://github.com/fisma-ready/github)
- [ ] Go through the [FISMA-Ready GitHub guide](https://github.com/fisma-ready/github)
to set up your GitHub account to be added to CISA.
- [ ] Once your GitHub account has been added to the `cisagov` organization,
make sure you're assigned to this issue.

#### Mandatory Training ####

- [ ] Complete [PALMS Cybersecurity Training](https://etms.hq.dhs.gov),
including Mandatory Cyber Security and Privacy Training, including accepting
including Mandatory Cyber Security and Privacy Training, and accepting
the Rules of Behavior, which is required before we can give you access to any
systems, like Trio.

Expand All @@ -70,7 +70,7 @@ Once you're set up on Microsoft Teams, we recommend you join the following:
### Getting to know the VM Fusion Dev Team ###

- [ ] Bookmark the [dev team project board] to track issues and work across
multiple Github repositories.
multiple GitHub repositories.
- [ ] Bookmark [VM JIRA] to work with the rest of VM Fusion.

### Trio Google Workspace ###
Expand Down Expand Up @@ -106,7 +106,7 @@ to be able to view and edit it.
Useful links:

- [ ] [NCATS Data Dictionary](https://github.com/cisagov/ncats-data-dictionary)
repo for information about what's stored in the MongoDB database
repo for information about what's stored in the CyHy environment MongoDB databases
- [ ] [CISA COOL AWS Accounts](https://docs.google.com/spreadsheets/d/1It0FIlG7ZxTwrRV-zVYUAMw18L6ZstQiAYT7vGYf5VE/edit#gid=2069139012)
sheet for AWS accounts reference
- [ ] [Performance Plans](https://docs.google.com/spreadsheets/d/1UaGI8u70CXOGBtvJFQ85vCkPbqyDh5PVws0Xu893piw/edit?ts=5e558417&pli=1#gid=474573185)
Expand All @@ -128,7 +128,7 @@ improved and open as PRs on the [template onboarding checklist].
## Required items for all team members ##

- [ ] Invite them to relevant recurring meetings.
- [ ] Invite them to relevant [Github cisagov teams](https://github.com/orgs/cisagov/teams/).
- [ ] Invite them to relevant [GitHub cisagov teams](https://github.com/orgs/cisagov/teams/).

## Required items for VM Fusion dev team members ##

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Heavily "inspired" by the

## Git, GitHub, and you ##

* [FISMA-Ready Github account setup](https://github.com/fisma-ready/github)
* [FISMA-Ready GitHub account setup](https://github.com/fisma-ready/github)
* [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/#seven-rules)

## Tools and services we use ##
Expand Down
8 changes: 4 additions & 4 deletions dev_envs/mac-env-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ option `iTerm2 > Make iTerm2 Default Term` to make it your default too.
To set up a dev environment via the [CISA `laptop` script](https://github.com/cisagov/laptop/),
execute the following in your terminal:

```console
```bash
bash <(curl --silent https://raw.githubusercontent.com/cisagov/laptop/master/laptop)
```

Expand Down Expand Up @@ -211,7 +211,7 @@ git config --global commit.gpgsign true

#### Generate `ssh` key to use git on the command line ####

Reference: [Github: Generating a new SSH key](https://docs.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent#adding-your-ssh-key-to-the-ssh-agent)
Reference: [GitHub: Generating a new SSH key](https://docs.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent#adding-your-ssh-key-to-the-ssh-agent)

Note: use `ed25519` instead of `rsa`

Expand All @@ -230,7 +230,7 @@ ssh-keygen -t ed25519

#### Add ssh key to GitHub ####

Reference: [Github: Adding a new SSH key to your GitHub account](https://docs.github.com/en/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account)
Reference: [GitHub: Adding a new SSH key to your GitHub account](https://docs.github.com/en/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account)

Note: use `ed25519` instead of `rsa`

Expand All @@ -239,7 +239,7 @@ Note: use `ed25519` instead of `rsa`
$ pbcopy < ~/.ssh/id_ed25519.pub
```

1. Load your [Github Settings page for adding an SSH key](https://github.com/settings/ssh/new)
1. Load your [GitHub Settings page for adding an SSH key](https://github.com/settings/ssh/new)
and paste the contents of your clipboard
1. Give this device a descriptive name and `Add SSH key`
1. Confirm your password to continue (if requested)
Expand Down

0 comments on commit d7d2e3f

Please sign in to comment.